Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Change expected master boot string for netboot back #173

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

plars
Copy link
Collaborator

@plars plars commented Dec 12, 2023

Description

For netboot images (just plano gadgets use this), there's an initramfs with a small binary that let's us push around images, reformat the drive, etc. There's a string that it sends back if you hit it to confirm that we are in that image, and this device connector needs to expect that properly, even though it uses old names.

Resolved issues

Right now, netboot provisioning won't work on a few devices because this is expecting the wrong thing back

Documentation

Tests

No changes, this is just changing the expected output back to how it previously was when it worked.

@plars plars requested a review from a team December 12, 2023 15:16
Copy link
Contributor

@kevinyehk kevinyehk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@plars plars merged commit 2929fe1 into main Dec 12, 2023
2 checks passed
@plars plars deleted the fix-netboot-image-boot-check branch December 12, 2023 15:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants