Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document ingress_per_unit lib dependencies #36

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

mmanciop
Copy link
Contributor

@mmanciop mmanciop commented Apr 5, 2022

Issue

Document the dependency of ingress_per_unit on the jsonschema package (which was transitively
imported by SDI with LIBPATCH 6 and below).

Solution

Provide more informative error message on the missing jsonschema dependency for charms using the ingress_per_unit library.

Some housekeeping on requirements.txt.

Context

N/A

Testing Instructions

N/A

Release Notes

Document the dependency of ingress_per_unit on the jsonschema package (which was transitively
imported by SDI with LIBPATCH 6 and below).

Document the dependency of ingress_per_unit on
the jsonschema package (which was transitively
imported by SDI with LIBPATCH 6 and below).

Provide more informative error message on the
missing jsonschema dependency for charms using
the ingress_per_unit library.

Some housekeeping on requirements.txt.
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.observability_libs.v0.kubernetes_service_patch was already up to date in version 0.6.                                                           
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.17.                                                                     
Library charms.traefik_k8s.v0.ingress was already up to date in version 0.5.   
Library charms.traefik_k8s.v0.ingress_per_unit has local changes, cannot be updated.                                                                           

stderr

@jnsgruk
Copy link
Member

jnsgruk commented Apr 13, 2022

@PietroPasotti let's get this merged in once the other has landed.

Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PietroPasotti PietroPasotti merged commit 5b42a51 into main Apr 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants