-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Traefik appends a tls
route even when tls
routes are explicitly provided
#450
Conversation
tls
route even when tls
routes are explicitly providedtls
route even when tls
routes are explicitly provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love all the red in this diff!
Are we expecting any charms to break due to
? |
tls
route even when tls
routes are explicitly providedtls
route even when tls
routes are explicitly provided
Unfortunately yes, it seems Tempo is relying on Traefik upgrading the connection, We'll have to keep the functionality and introduce a backward compatible way to allow charm authors to opt out of getting automated TLS routes and at the same time not breaking charms that depend on it. |
tls
route even when tls
routes are explicitly providedtls
route even when tls
routes are explicitly provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue
Fixes #430
Context
For every route,
traefik
created a duplicate routeROUTENAME-tls
for the same rule and service but with additional TLS configuration. Both applied to the same rule and thus conflict, and the newROUTENAME-tls
route takes precedence over the originalROUTENAME
because its name is longer.Solution
raw
in the interface.raw
is set toTrue
, Traefik will only append TLS routes to HTTP routes.ROUTENAME-tls
routes.Testing
Tandem PR: canonical/grafana-k8s-operator#391