Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update project #3

Merged
merged 4 commits into from
May 12, 2019
Merged

Update project #3

merged 4 commits into from
May 12, 2019

Conversation

caojiele
Copy link
Owner

What is the purpose of the change

Update project
Fix issue.

Brief changelog

[DUBBO-3137]: step3 - seperate constants for remoting (apache#4023)
optimize some code style (apache#4006 apache#4031)
use equal explicit class to replace anonymous class (apache#4027)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

CrazyHZM and others added 4 commits May 11, 2019 17:38
* constants step3-remoting

* remove import

* modify
* optimize constant naming style
* optimize some code style
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
@caojiele caojiele merged commit 9754cba into caojiele:master May 12, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants