-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add reflect function wrapper to allow always passing iterations #1012
Conversation
Should I add in a reflectAll helper as well? |
Sure. It's pretty simple though -- |
02c1322
to
83ded82
Compare
…a object with error or value property set. This is one way to solve issue caolan#942.
Added reflectAll as well as rebased off master. I'll wait for the other PR to be merged in and then refactor for that. |
You should be good to go for your refactoring. 👍 |
@jtwebman Any update? This is the last change for the 2.0 release. |
@aearly I can get this in tomorrow for you. Been moving the family to Portland the last two weeks. |
Ah, no rush. Worst case, we save it for 2.1. |
@jtwebman How are things going? Should we save this for a later release? |
Sorry about the delay, was down and out sick. Working on it tonight. |
I an going to close this PR as I opened a new one for this as the files changed and merged freaked out. #1095 |
Add reflect that wraps a function with a always passing callback and a object with error or value property set.
This is one way to solve issue #942.