Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add reflect function wrapper to allow always passing iterations #1012

Closed
wants to merge 1 commit into from

Conversation

jtwebman
Copy link
Contributor

Add reflect that wraps a function with a always passing callback and a object with error or value property set.

This is one way to solve issue #942.

@aearly
Copy link
Collaborator

aearly commented Feb 2, 2016

👍 @megawac What do you think?

We're probably going to hold of on merging this until #996 is complete, though,

@jtwebman
Copy link
Contributor Author

jtwebman commented Feb 5, 2016

Should I add in a reflectAll helper as well?

@aearly
Copy link
Collaborator

aearly commented Feb 9, 2016

Sure. It's pretty simple though -- async.reflectAll(tasks) vs. tasks.map(async.reflect).

@jtwebman jtwebman force-pushed the collect_resume_behavior branch 2 times, most recently from 02c1322 to 83ded82 Compare February 18, 2016 00:55
…a object with error or value property set.

This is one way to solve issue caolan#942.
@jtwebman
Copy link
Contributor Author

Added reflectAll as well as rebased off master. I'll wait for the other PR to be merged in and then refactor for that.

@aearly aearly added this to the 2.0 milestone Feb 25, 2016
@aearly
Copy link
Collaborator

aearly commented Feb 25, 2016

You should be good to go for your refactoring. 👍

@aearly
Copy link
Collaborator

aearly commented Mar 9, 2016

@jtwebman Any update? This is the last change for the 2.0 release.

@jtwebman
Copy link
Contributor Author

jtwebman commented Mar 9, 2016

@aearly I can get this in tomorrow for you. Been moving the family to Portland the last two weeks.

@aearly
Copy link
Collaborator

aearly commented Mar 10, 2016

Ah, no rush. Worst case, we save it for 2.1.

@aearly
Copy link
Collaborator

aearly commented Mar 28, 2016

@jtwebman How are things going? Should we save this for a later release?

@jtwebman
Copy link
Contributor Author

jtwebman commented Apr 4, 2016

Sorry about the delay, was down and out sick. Working on it tonight.

@jtwebman
Copy link
Contributor Author

jtwebman commented Apr 4, 2016

I an going to close this PR as I opened a new one for this as the files changed and merged freaked out. #1095

@jtwebman jtwebman closed this Apr 4, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants