Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: override baseURL in Nitro #60

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

OlaAlsaker
Copy link
Contributor

@OlaAlsaker OlaAlsaker commented Dec 6, 2023

nuxt/nuxt#23841 breaks this package when building and running the app in production.

Setting nitro.runtimeConfig.app.baseURL to ./ will fix the problem, making nuxt-electron compatible with Nuxt 3.8.1 and up.

@OlaAlsaker OlaAlsaker mentioned this pull request Dec 6, 2023
@caoxiemeihao
Copy link
Owner

Thanks for this PR, great!

@caoxiemeihao caoxiemeihao merged commit f11608a into caoxiemeihao:main Dec 9, 2023
@caoxiemeihao caoxiemeihao mentioned this pull request Dec 10, 2023
@OlaAlsaker OlaAlsaker deleted the fix-nitro-config branch December 11, 2023 08:58
@tuquet
Copy link

tuquet commented Dec 21, 2023

Thanks for this PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants