catch exception, column output change #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaffar
requested review from
fdosani,
ak-gupta,
jdawang and
gladysteh99
as code owners
Tests passing |
fdosani
approved these changes
Nov 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProgrammingError, but it seems on rare occasion it will throw the exact same error with the same message as aDatabaseError. Unsure as to what's happening in the Snowflake backend to cause this, but we should catch both to be safe. SnowparkClientException catch has been removed - it was intended to catch general Snowpark exceptions, but these diff failures come from Snowflake itself failing to calculate the diff, not from Snowpark.Will post passing tests as soon as tests are done running