-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add icmpv4 redirect message #107
Conversation
core/src/packets/icmp/v4/redirect.rs
Outdated
|
||
/// Sets the gateway ip address | ||
#[inline] | ||
fn set_gateway(&mut self, gateway: Ipv4Addr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll want to make this pub if it's settable, then the lint error should go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weirdly enough gh-actions doesn't see the change for some reason:
error: method is never used: `body_mut`
--> core/src/packets/icmp/v4/redirect.rs:58:5
|
58 | fn body_mut(&mut self) -> &mut RedirectBody {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
error: method is never used: `set_gateway`
--> core/src/packets/icmp/v4/redirect.rs:70:5
|
70 | fn set_gateway(&mut self, gateway: Ipv4Addr) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530abf9
to
ca38432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really great work! a few small comments.
ca38432
to
ad592ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @ari23.
Description
Adds support for ICMPv4 Redirect Message defined in IETF RFC 792
Type of change
Checklist