Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement Destination Unreachable for ICMPv6 #128

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

plumenator
Copy link
Contributor

@plumenator plumenator commented Feb 27, 2021

Co-authored-by: @Adenylatcyclase

Description

Fixes # (issue) - if applicable

Type of change

  • Bug fix
  • New feature
  • New protocol
  • Breaking change
  • Documentation update

Checklist

  • Associated tests
  • Associated documentation

We based it on Time Exceeded, pretty much copy pasted and renamed identifiers. 😁
This should tick one box off #105

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #128 (51bc0e0) into master (e4f542b) will decrease coverage by 0.01%.
The diff coverage is 68.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   68.57%   68.55%   -0.02%     
==========================================
  Files          65       66       +1     
  Lines        5906     5973      +67     
==========================================
+ Hits         4050     4095      +45     
- Misses       1856     1878      +22     
Impacted Files Coverage Δ
core/src/packets/icmp/v6/mod.rs 79.52% <ø> (ø)
...ore/src/packets/icmp/v6/destination_unreachable.rs 68.65% <68.65%> (ø)
core/src/testils/proptest/strategy.rs 82.24% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f542b...51bc0e0. Read the comment docs.

@zeeshanlakhani
Copy link
Member

zeeshanlakhani commented Feb 27, 2021

@plumenator @Adenylatcyclase very cool to see this. Before @drunkirishcoder and I give it a good review, can you rebase and bring in the latest changes from the main branch? We changed our error library recently.

Co-authored-by: Adenylatcyclase <streicher1993@googlemail.com>
@plumenator
Copy link
Contributor Author

Done!

@zeeshanlakhani
Copy link
Member

Thanks @plumenator @Adenylatcyclase. We'll take a gander this week.

Copy link
Contributor

@drunkirishcoder drunkirishcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution! good work.

Copy link
Member

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and for keeping up w/ our documentation approach too!

@zeeshanlakhani zeeshanlakhani merged commit 8dd1dd9 into capsule-rs:master Mar 7, 2021
@plumenator plumenator deleted the icmpv6_dest_unreach branch April 18, 2021 13:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants