Update Go versions in all modules #24
Conversation
terryyylim
force-pushed
the
update-modules-go-version
branch
4 times, most recently
from
7a0a0c9 to
86a8c78
Compare
terryyylim
force-pushed
the
update-modules-go-version
branch
from
86a8c78 to
3deb700
Compare
.github/workflows/plugins.yml
Outdated
| id: setup-go | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.16 | ||
| go-version: "1.17" |
There was a problem hiding this comment.
golangci-lint does not currently support Go 1.18 fully yet (golangci/golangci-lint#2649), hence pinning to Go 1.17 for linting workflows.
There was a problem hiding this comment.
Can we instead use v2 of the action which seems to support Go1.18 (ref)? That's what Turing is using too.
There was a problem hiding this comment.
Oh, I misread your comment, the issue here is with golangci-lint, i.e if we use Go 1.18, the linter will fail.
There was a problem hiding this comment.
Umm I think you changed the wrong action earlier. I meant golangci/golangci-lint-action@v3.
You can refer to this: https://github.com/gojek/turing/blob/main/.github/workflows/turing.yaml#L242
There was a problem hiding this comment.
Oh, I thought you meant setup. Ok I've updated that. I also refactored the versions to be part of environment variables so it'll be easier to change versions moving forward.
.github/workflows/plugins.yml
Outdated
| id: setup-go | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.16 | ||
| go-version: "1.17" |
There was a problem hiding this comment.
Can we instead use v2 of the action which seems to support Go1.18 (ref)? That's what Turing is using too.
.github/workflows/plugins.yml
Outdated
| @@ -51,6 +51,11 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: Set up Go 1.18 | |||
There was a problem hiding this comment.
Most of the changes to this file can be reverted after resolving: #24 (comment)
What this PR does / why we need it:
This PR is to keep our Go version up-to-date, by upgrading from
1.16to1.18.Which issue(s) this PR fixes:
NONE