[HierarchyList] Test coverage, conditional rendering, and defaultSelected expansion #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone2423
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
filipecorrea,
jessieyan,
leetosc,
scottdickerson,
stuckless,
tay1orjones and
tomklapiscak
as code owners
|
Deploy preview for carbon-addons-iot-react ready! Built with commit b070956 https://deploy-preview-904--carbon-addons-iot-react.netlify.com |
bryancboyd
approved these changes
Feb 17, 2020
| export const searchForItemId = (item, searchId) => { | ||
| if ( | ||
| // Check if the value or secondary value has a match | ||
| item.id.toLowerCase().search(searchId.toLowerCase()) !== -1 |
There was a problem hiding this comment.
Can't this function and searchForItemValue be refactored into one to take a list of content keys to search for so the same codebase can be shared?
There was a problem hiding this comment.
Refactored and made a general util search function
added 3 commits
February 17, 2020 12:07
tay1orjones
approved these changes
Feb 17, 2020
|
🎉 This PR is included in version 2.42.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #892
Summary
secondaryValuediv was still being rendered, even when it was nulldefaultSelectId's parent elements are now expanded by defaultdefaultSelectedIdChange List (commits, features, bugs, etc)
ListItem. IfsecondaryValueis null, it will not render, freeing up the other 50% of the widthiddefaultSelectedIdbehaviortoBeTruthy()functions renamed totoBeInTheDocument()where applicable to give a better idea of what I am actually testing fordefaultSelectedId's DOM elementAcceptance Test (how to verify the PR)