This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(modal): backport onTransitionEnd NPE and modal focus fixes to v6 #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by `onTransitionEnd` on a child element in modal, presumably
when modal node ref hasn't been ready yet.
Fixes #2140.
…rbon-design-system#2163) * fix(Modal): get focus behavior in sync with/without focus-trap * fix(modal): remove unused focus-trap, createFocusTrap * chore(modal): update snapshots
asudoh
approved these changes
Apr 18, 2019
dakahn
approved these changes
Apr 19, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of: #2141 and #2163 for v6.