Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add bazel query flag to work around bug #414

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Add bazel query flag to work around bug #414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
019d9c9
Add Bazel query flag to work around https://github.com/bazelbuild/baz…
geoffromer Mar 23, 2021
583f8bf
Respond to reviewer comments.
geoffromer Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/create_compdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@
"query",
"--keep_going",
"--output=location",
# Workaround for https://github.com/bazelbuild/bazel/issues/8900
"--incompatible_display_source_file_location",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave a comment to warn our future selves about this sharp edge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

'filter(".*\\.(h|cpp|cc|c|cxx)$", kind("source file", deps(//...)))',
],
check=True,
Expand Down