Move common entity fields to a 'base' struct. #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per discussion, restructured from a |
zygoloid
approved these changes
Jul 24, 2024
Comment on lines
+38
to
+40
| auto PrintBaseFields(llvm::raw_ostream& out) const -> void { | ||
| out << "name: " << name_id << ", parent_scope: " << parent_scope_id; | ||
| } |
There was a problem hiding this comment.
It seems a bit weird to mention the "Base" in the name here. Maybe we could just call this PrintFields, shadow it in the derived class when necessary, and have Printable<T> call PrintFields if it exists:
struct EntityWithParamsBase {
auto PrintFields(llvm::raw_ostream& out) const -> void { ... }
// ...
}
struct Function : EntityWithParamsBase, FunctionFields, Printable<Function> {
auto PrintFields(llvm::raw_ostream& out) const -> void {
EntityWithParamsBase::PrintFields(out);
out << ...function fields...
}
};But I'm happy to leave that to later given that this is already a large PR.
brymer-meneses
pushed a commit
to brymer-meneses/carbon-lang
that referenced
this pull request
Aug 15, 2024
I'd considered moving DeclParams uses over, but when handling qualified names, there's a parse node instead of an instruction. I did try to unify a couple other uses though, including adding MergeDefinition. I expect `interface` will use a little more once it's more completely implemented, but maybe I'm wrong about that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd considered moving DeclParams uses over, but when handling qualified names, there's a parse node instead of an instruction. I did try to unify a couple other uses though, including adding MergeDefinition. I expect
interfacewill use a little more once it's more completely implemented, but maybe I'm wrong about that.