Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reformat CompilationUnit function definitions out-of-line #4825

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Jan 21, 2025

The Driver::CompilationUnit class is defined with multiple long function definitions inline. This change moves those definitions out-of-line.

Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This TODO had slipped my mind. :)

@jonmeow jonmeow enabled auto-merge January 21, 2025 16:14
@jonmeow jonmeow added this pull request to the merge queue Jan 21, 2025
Merged via the queue into carbon-language:trunk with commit a664801 Jan 21, 2025
10 checks passed
@clavin clavin deleted the refactor_out_of_line branch January 21, 2025 16:53
dwblaikie pushed a commit to dwblaikie/carbon-lang that referenced this pull request Jan 21, 2025
…anguage#4825)

The `Driver::CompilationUnit` class is defined with multiple long
function definitions inline. This change moves those definitions
out-of-line.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants