Refactor diagnostic_emitter.h #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #4870, the actual change here is the 2nd commit |
jonmeow
force-pushed
the
diagnostic-converter-refactor
branch
from
e2ccb2e to
f4e8339
Compare
jonmeow
force-pushed
the
diagnostic-converter-refactor
branch
from
f4e8339 to
f46d9b1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning on eliminating DiagnosticConverter. As part of this, collapse it into diagnostic_emitter.h, and refactoring the header a little so that it's more readable when making changes.