Diagnose var in interfaces
#4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was ignored, and then carbon-language#4720 accidentally made it a crash bug
danakj
reviewed
Feb 6, 2025
| @@ -386,6 +386,12 @@ auto HandleParseNode(Context& context, Parse::VariableDeclId node_id) -> bool { | |||
| } | |||
| return true; | |||
| } | |||
| if (context.GetCurrentScopeAs<SemIR::InterfaceDecl>()) { | |||
| CARBON_DIAGNOSTIC(VarInInterfaceDecl, Error, | |||
| "interfaces cannot have `var` members"); | |||
There was a problem hiding this comment.
The style guide wants to say what occurred, rather than what cannot occur: https://github.com/carbon-language/carbon-lang/blob/40f3de2c0726983c7c41200eddd479ceec00be5e/toolchain/docs/diagnostics.md#diagnostic-message-style-guide
Maybe "var binding found in interface"?
There was a problem hiding this comment.
Thanks, I wasn't thinking about that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was ignored, and then #4720 accidentally made it a crash bug