Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CIP-0034 | Update registry.json to reflect Preview and Pre-Production test networks #332

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Sep 23, 2022

Update to CIP-34 to reflect the addition of new testnets (see here) and removal of the legacy testnet.

@rphair rphair added the Correction Fixing minor issue or typo label Sep 23, 2022
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have experience in this area but I confirm the hashes match the configs in the reference document. @SebastienGllmt can you confirm the values are correct?

@KtorZ
Copy link
Member

KtorZ commented Sep 27, 2022

Orthogonal to this proposal, we should probably seek to disambiguate what "genesis hash" refers to. There are now technically 3 genesis hashes per network (Byron, Shelley & Alonzo) and maybe more in the future.

Might be relevant to #323

@KtorZ KtorZ merged commit 359988c into cardano-foundation:master Oct 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Correction Fixing minor issue or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants