Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CIP-0114? | CBOR Tags Registry #752

Merged
merged 17 commits into from
Mar 6, 2024
Merged

CIP-0114? | CBOR Tags Registry #752

merged 17 commits into from
Mar 6, 2024

Conversation

stevenj
Copy link
Contributor

@stevenj stevenj commented Jan 25, 2024 •
edited
Loading

Draft CIP for a proposed solution to: #751

This is the first of three PRs that should be considered together for context.

See also:

Closes input-output-hk#3

(in branch: CIP text, proposed registry & schema)

@stevenj stevenj marked this pull request as draft January 25, 2024 13:57
Ryun1
Ryun1 reviewed Jan 25, 2024
View reviewed changes
Ryun1
Ryun1 reviewed Jan 25, 2024
View reviewed changes
@rphair rphair added Category: Meta Proposals belonging to the 'Meta' category. Category: Metadata Proposals belonging to the 'Metadata' category. and removed Category: Meta Proposals belonging to the 'Meta' category. labels Jan 25, 2024
@stevenj stevenj mentioned this pull request Jan 26, 2024
Merged
@stevenj stevenj changed the title CIP-???? | CBOR Tags for Cardano Data Structures and Registry CIP-???? | CBOR Tag definition for CIP-0003 ED25519-BIP32 Keys Jan 26, 2024
@stevenj stevenj changed the title CIP-???? | CBOR Tag definition for CIP-0003 ED25519-BIP32 Keys CIP-???? | CBOR Tags for Cardano Data Structures and Registry Jan 26, 2024
@stevenj stevenj marked this pull request as ready for review January 26, 2024 12:23
@stevenj stevenj mentioned this pull request Jan 26, 2024
Merged
@rphair rphair mentioned this pull request Jan 31, 2024
Merged
Crypto2099
Crypto2099 reviewed Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks well-defined and has a clear use case for the ecosystem and the ever-growing list of supported keys and hash types that may be found in the ledger.

Ryun1
Ryun1 reviewed Feb 4, 2024
View reviewed changes
Ryun1
Ryun1 reviewed Feb 4, 2024
View reviewed changes
@rphair rphair changed the title CIP-???? | CBOR Tags for Cardano Data Structures and Registry CIP-???? | CBOR Tags Registry Feb 6, 2024
@rphair rphair changed the title CIP-???? | CBOR Tags Registry CIP-0114? | CBOR Tags Registry Feb 6, 2024
rphair
rphair reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenj - promoted to candidate along with all CBOR submissions at CIP meeting today. 🎉

@rphair rphair mentioned this pull request Feb 6, 2024
Merged
rphair
rphair reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category settlement as per #752 (comment):

This was referenced Mar 5, 2024
Closed
Closed
stevenj and others added 4 commits March 5, 2024 14:06
@stevenj @Crypto2099
Update CIP-xxxx/README.md
ef51130 
Co-authored-by: Adam Dean <63186174+Crypto2099@users.noreply.github.com>
@stevenj @Ryun1
Update CIP-xxxx/README.md
b2f3877 
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
@stevenj @rphair
Update CIP-xxxx/README.md
bf742d4 
Co-authored-by: Robert Phair <rphair@cosd.com>
@stevenj @rphair
Update CIP-xxxx/README.md
f348ae1 
Co-authored-by: Robert Phair <rphair@cosd.com>
@stevenj
Copy link
Contributor Author

stevenj commented Mar 5, 2024

I have addressed all comments except for the Acceptance criteria as noted above.

Ryun1
Ryun1 reviewed Mar 5, 2024
View reviewed changes
Ryun1
Ryun1 reviewed Mar 5, 2024
View reviewed changes
Ryun1
Ryun1 reviewed Mar 5, 2024
View reviewed changes
@rphair rphair mentioned this pull request Mar 5, 2024
Merged
@stevenj @Ryun1
Update CIP-0114/README.md
5dff35d 
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Ryun1
Ryun1 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

rphair
rphair approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @stevenj (& @Ryun1 for checking every detail)... looking like all pending issues have been addressed in last round of commits.

@rphair rphair merged commit b013dd0 into cardano-foundation:master Mar 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Crypto2099 Crypto2099 Crypto2099 left review comments

@rphair rphair rphair approved these changes

@Ryun1 Ryun1 Ryun1 approved these changes

Assignees
No one assigned
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CIP for Creating a CBOR Tags Registry
4 participants
@stevenj @rphair @Ryun1 @Crypto2099