Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ui): KERIA down or connectivity issues during SSI setup #981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Feb 26, 2025

Description

Display new error message when KERIA down or connectivity issues during SSI setup

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Browser

Network Issue
Screen.Recording.2025-02-26.at.14.35.24.mov

@sdisalvo-crd sdisalvo-crd requested a review from obstar February 26, 2025 09:47
@iFergal
Copy link
Collaborator

iFergal commented Feb 26, 2025

Why are we showing that same error if the server was up but gave us the 404 that the agent does not exist? This means the seed phrase is wrong. That's a different error.

@iFergal
Copy link
Collaborator

iFergal commented Feb 26, 2025

The core already throws different errors for this:

  • Network error: Agent.KERIA_CONNECT_FAILED_BAD_NETWORK
  • 404/bad seed phrase: Agent.KERIA_NOT_BOOTED
  • Other error, which can be a something went wrong toast like before: Agent.KERIA_BOOTED_ALREADY_BUT_CANNOT_CONNECT

@@ -52,6 +53,7 @@ import { OnboardingMode } from "../../components/SwitchOnboardingModeModal/Switc

const SSI_URLS_EMPTY = "SSI url is empty";
const SEED_PHRASE_EMPTY = "Invalid seed phrase";
const SEED_PHRASE_NOT_BOOTED = "agent does not exist for controller";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to check cause for this one because the error is already specific Agent.KERIA_CONNECT_FAILED_BAD_NETWORK

Copy link
Collaborator Author

@Sotatek-DukeVu Sotatek-DukeVu Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iFergal and sorry I got confused with the requirements.

@Sotatek-DukeVu Could you please take a look?

@Sotatek-DukeVu
Copy link
Collaborator Author

Sotatek-DukeVu commented Feb 27, 2025

@iFergal
Why are we showing that same error if the server was up but gave us the 404 that the agent does not exist? This means the seed phrase is wrong. That's a different error.
I updated. Please take a look

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the fix/DTIS-1926-keria-down-or-connectivity-issue branch from 4d36148 to 012e016 Compare February 27, 2025 04:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants