Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(ui): i18n: considerations #985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): i18n: considerations #985

wants to merge 1 commit into from

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Feb 27, 2025 •
edited
Loading

Description

Add UTC offset on date time field

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Switch timezone

1000005189.mp4

Identifier Detail

IOS
Screenshot 2025-02-27 at 16 50 11
Android

Screenshot_20250227_145124

Advance

IOS
Screenshot 2025-02-27 at 16 50 16
Android

Screenshot_20250227_171216

Connections

IOS
Screenshot 2025-02-27 at 16 50 53
Android

Screenshot_20250227_151252

Credential Detail

IOS
Screenshot 2025-02-27 at 16 51 23
Android

Screenshot_20250227_171128

@sdisalvo-crd
Copy link
Contributor

In the video we can see how Duke switches between timezones and that will change the time and date in the same Identifier.

Here is a screenshot with a side by side comparison.

28022025094423

@sdisalvo-crd sdisalvo-crd self-requested a review February 28, 2025 10:01
@sdisalvo-crd sdisalvo-crd requested a review from obstar February 28, 2025 10:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sdisalvo-crd sdisalvo-crd sdisalvo-crd approved these changes

@obstar obstar Awaiting requested review from obstar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sotatek-DukeVu @sdisalvo-crd