-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Commit blueprint tx #1380
Commit blueprint tx #1380
Conversation
c6deea1
to
aa16136
Compare
2857ae4
to
cf0cae1
Compare
Test Results423 tests +2 414 ✅ +2 14m 41s ⏱️ -54s Results for commit 62371ed. ± Comparison against base commit 120ff1b. This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
beaed87
to
a756ce7
Compare
679efde
to
934703e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct! Only some dead code / specifications to be taken care of.
I do expect we go through this diff and my suggestions in an ensemble session today.
4f57516
to
2e29b3d
Compare
20b99e5
to
987e9bc
Compare
8c17fba
to
a363e08
Compare
1c868a2
to
252bbf0
Compare
252bbf0
to
5550b7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be correct now. Only minor things pointed out, although some inconsistencies are ideally cleaned up before merging this.
fix #1350
As discussed with out users in #1337 we want to unlock more usecases and allow additional transaction context specified by providing a blueprint transaction.
It is important to note that only the inputs spent by the blueprint transaction will be committed to a head.
Any outputs as well as minting or burning will be igored by the hydra-node
The old way of committing still works with a caveat that only the pub key
UTxO
can be committed this way. In order to commit a scriptUTxO
we need a draft/blueprint transaction that proves these outputs can be spent and provides necessary data (i.e. redeemers).Now it is possible to also commit reference inputs since we lifted this restriction.