Use CHaP 🤖 #576
Merged
Use CHaP 🤖 #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
v0d1ch
approved these changes
Oct 21, 2022
ghost
approved these changes
Oct 21, 2022
|
|
||
| Because of how we use Nix to manage our Haskell build, whenever you do this you | ||
| will also need to pull in the Nix equivalent of the newer `index-state`. You can | ||
| do this by bumping the `haskellNix` to a newer tag in our `default.nix`. |
There was a problem hiding this comment.
Suggestion: Mention the possibility of a conflict, eg. trying to pull newer hackage index than supported by haskell.nix? It happened to me a couple of months ago
| @@ -349,7 +349,7 @@ test-suite tests | |||
| , plutus-ledger-api | |||
| , process | |||
| , QuickCheck | |||
| , quickcheck-dynamic | |||
| , quickcheck-dynamic <2.0.0 | |||
There was a problem hiding this comment.
this formatting looks weird, I guess that's cabal-fmt but I am not keen on "tables" in text
There was a problem hiding this comment.
Yes. This was automatic by cabal-fmt
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
This will make dependency management (hopefully) a lot simpler and improve UX with cabal and nix(haskell.nix)
This will result in quite some rebuilds, but our nix cache is now containing ALL the cardano haskell packages 🎉
For some reason we need to fetch the CHaP index and this does not play well with pure nix-shells. Alternative would've been to add TLS capability to the nix-shell .. I guess. But this is not important enough that I would bother now.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 The Cardano Haskell Packages (CHaP) will make our life's simpler by forcing our upstream dependencies to version & release their code, and we don't need to keep
source-repository-packageentries in thecabal.project🤖 Added the CHaP index to
cabal.projectand made it work using nix. The nix shell will now compile (or download) & provide most third-party dependencies to us.🤖 Only exception:
cardano-apiwhere only version1.35.3is in CHaP, which does not include our upstreamed changes. Needed to backport the two commits and keep thesource-repository-packagestanza for that one.