Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace atty dependency with is-terminal #57

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

AlexTMjugador
Copy link
Contributor

The rationale for this change is explained at #56. is-terminal has a MSRV of 1.48, so we need to bump our MSRV to match.

I have taken care of updating the documentation and CI workflows with the new MSRV. A new Cargo.lock.msrv file was generated by executing cargo +1.48 check on a workstation with the Rust 1.48 toolchain installed.

The rationale for this change is explained at
cardoe#56. `is-terminal` has a
MSRV of 1.48, so we need to bump our MSRV to match.

I have taken care of updating the documentation and CI workflows with
the new MSRV. A new `Cargo.lock.msrv` file was generated by executing
`cargo +1.48 check` on a workstation with the Rust 1.48 toolchain
installed.
@epilys
Copy link

epilys commented Jan 16, 2024

@cardoe ping/bump

@AlexTMjugador
Copy link
Contributor Author

Now that there is some activity on this PR, I think it's worth mentioning that Rust stabilized the IsTerminal trait as a part of the standard library on version 1.70 (released on April 2023), so if bumping MSRV further is not an issue, we can use that instead.

@cardoe
Copy link
Owner

cardoe commented Jan 18, 2024

Guess we should look at what log is targeting and update in one big move.

@AlexTMjugador
Copy link
Contributor Author

The latest log crate version, v0.4.20, targets a MSRV of 1.60, which does not guarantee the stabilization of the IsTerminal trait.

@epilys
Copy link

epilys commented Jan 29, 2024

Could we feature-gate this and make IsTerminal opt-in? If it's possible we could satisfy everyone.

@AlexTMjugador
Copy link
Contributor Author

AlexTMjugador commented Jan 30, 2024

Going along with log's MSRV is sensible, and the impact for newer Rust version users of having the extra is-terminal dependency is negligible.

I would suggest merging this PR as-is, without extra features (whose eventual removal would be a backwards incompatible change, by the way). Once log targets a MSRV of 1.70, we can update stderrlog-rs to match, and transparently remove the dependency on is-terminal. We also could keep waiting for log to target a MSRV of 1.70 and go directly to step 2 of this plan, I guess...

@cardoe cardoe merged commit 037fdc0 into cardoe:master Jan 30, 2024
@epilys
Copy link

epilys commented Jan 31, 2024

Thank you @cardoe, are you planning on making a crates.io release soon?

@cardoe
Copy link
Owner

cardoe commented Jan 31, 2024

Soon as I can convince CI to stop misbehaving.

@cardoe
Copy link
Owner

cardoe commented Jan 31, 2024

Should be out now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants