-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace atty
dependency with is-terminal
#57
Conversation
The rationale for this change is explained at cardoe#56. `is-terminal` has a MSRV of 1.48, so we need to bump our MSRV to match. I have taken care of updating the documentation and CI workflows with the new MSRV. A new `Cargo.lock.msrv` file was generated by executing `cargo +1.48 check` on a workstation with the Rust 1.48 toolchain installed.
@cardoe ping/bump |
Now that there is some activity on this PR, I think it's worth mentioning that Rust stabilized the |
Guess we should look at what |
The latest |
Could we feature-gate this and make |
Going along with I would suggest merging this PR as-is, without extra features (whose eventual removal would be a backwards incompatible change, by the way). Once |
Thank you @cardoe, are you planning on making a crates.io release soon? |
Soon as I can convince CI to stop misbehaving. |
Should be out now. |
The rationale for this change is explained at #56.
is-terminal
has a MSRV of 1.48, so we need to bump our MSRV to match.I have taken care of updating the documentation and CI workflows with the new MSRV. A new
Cargo.lock.msrv
file was generated by executingcargo +1.48 check
on a workstation with the Rust 1.48 toolchain installed.