Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incomplete lidar points cloud when sensor_tick doesn't match simulation frequency #680

Open
Paul-Nico opened this issue Jun 6, 2023 · 2 comments

Comments

@Paul-Nico
Copy link

Hello, I noticed a bug on the lidar sensor : if simulation frequency is higher than lidar frequency, the published lidar point cloud will only contains data produced on the last simulation tick, and will then be incomplete.
I have written a simple fix for that, which stack the produced lidar data when the simulation ticks and publish the whole packet when the sensors ticks. I would be happy to do a pull request if possible.
Best regards,
Paul

Paul-Nico pushed a commit to Paul-Nico/ros-bridge that referenced this issue Jun 8, 2023
…nsor_tick different from simulation tick
Paul-Nico pushed a commit to Paul-Nico/ros-bridge that referenced this issue Jun 8, 2023
Paul-Nico pushed a commit to Paul-Nico/ros-bridge that referenced this issue Jun 8, 2023
@oliver-schumann
Copy link

Thank you for this branch! I stumbled over this problem some months ago and you just made my day!
I also ported it to the semantic lidar. Works like a charm :)

@Paul-Nico
Copy link
Author

Thank you for this branch! I stumbled over this problem some months ago and you just made my day! I also ported it to the semantic lidar. Works like a charm :)

Glad this helped :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants