-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/pull in more upstream fixes #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes a regex issue seen in uptream code.
- ensured new method works with older types as well.
- 206 passing 6 failing.
- stuck with current regex. - added new regex.
- figured out a system of regex. I don't want to get rid of the original regex's, instead we try the new ones first and fall back to the old ones just in case.
- tweaking to get all UTs to pass, not just helper uts.
…com/carlkidcrypto/ezsnmp into feature/pull_in_more_upstream_fixes
Valgrind Comment
|
Valgrind Comment
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address upstream issue/PR.
easysnmp/easysnmp#85
easysnmp/easysnmp#87
@charlestolley and @joshdcox feel free to give this a shot.