Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/pull in more upstream fixes #134

Merged
merged 15 commits into from
Jul 30, 2024

Conversation

carlkidcrypto
Copy link
Owner

This PR attempts to address upstream issue/PR.

easysnmp/easysnmp#85
easysnmp/easysnmp#87

@charlestolley and @joshdcox feel free to give this a shot.

carlkidcrypto and others added 14 commits April 2, 2024 06:55
- fixes a regex issue seen in uptream code.
- ensured new method works with older types as well.
- 206 passing
6 failing.
- stuck with current regex.
- added new regex.
- figured out a system of regex.
I don't want to get rid of the original regex's, instead we try the new ones first and fall back to the old ones just in case.
- tweaking to get all UTs to pass, not just helper uts.
Repository owner deleted a comment from github-actions bot Jul 20, 2024
Repository owner deleted a comment from github-actions bot Jul 20, 2024
Copy link

Valgrind Comment

Python Version Results OS Version
3.8 sh ==8267== LEAK SUMMARY: ==8267== definitely lost: 112 bytes in 7 blocks ==8267== indirectly lost: 0 bytes in 0 blocks ==8267== possibly lost: 91,872 bytes in 146 blocks ==8267== still reachable: 2,299,931 bytes in 1,307 blocks ==8267== suppressed: 74,488 bytes in 178 blocks ==8267== Reachable blocks (those to which a pointer was found) are not shown. ==8267== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.9 sh ==8257== LEAK SUMMARY: ==8257== definitely lost: 112 bytes in 7 blocks ==8257== indirectly lost: 0 bytes in 0 blocks ==8257== possibly lost: 301,313 bytes in 465 blocks ==8257== still reachable: 2,534,823 bytes in 1,549 blocks ==8257== suppressed: 68,037 bytes in 163 blocks ==8257== Reachable blocks (those to which a pointer was found) are not shown. ==8257== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.10 sh ==8149== LEAK SUMMARY: ==8149== definitely lost: 112 bytes in 7 blocks ==8149== indirectly lost: 0 bytes in 0 blocks ==8149== possibly lost: 255,208 bytes in 389 blocks ==8149== still reachable: 1,875,823 bytes in 1,470 blocks ==8149== suppressed: 68,403 bytes in 163 blocks ==8149== Reachable blocks (those to which a pointer was found) are not shown. ==8149== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.11 sh ==8163== LEAK SUMMARY: ==8163== definitely lost: 3,936 bytes in 11 blocks ==8163== indirectly lost: 8,579 bytes in 9 blocks ==8163== possibly lost: 3,568 bytes in 5 blocks ==8163== still reachable: 3,631,864 bytes in 2,640 blocks ==8163== suppressed: 69,898 bytes in 166 blocks ==8163== Reachable blocks (those to which a pointer was found) are not shown. ==8163== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.12 sh ==8170== LEAK SUMMARY: ==8170== definitely lost: 3,952 bytes in 11 blocks ==8170== indirectly lost: 1,026 bytes in 2 blocks ==8170== possibly lost: 3,568 bytes in 5 blocks ==8170== still reachable: 3,551,170 bytes in 2,598 blocks ==8170== suppressed: 68,382 bytes in 163 blocks ==8170== Reachable blocks (those to which a pointer was found) are not shown. ==8170== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest

Copy link

Valgrind Comment

Python Version Results OS Version
3.8 sh ==8303== LEAK SUMMARY: ==8303== definitely lost: 112 bytes in 7 blocks ==8303== indirectly lost: 0 bytes in 0 blocks ==8303== possibly lost: 73,792 bytes in 116 blocks ==8303== still reachable: 2,157,492 bytes in 1,174 blocks ==8303== suppressed: 74,488 bytes in 178 blocks ==8303== Reachable blocks (those to which a pointer was found) are not shown. ==8303== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.9 sh ==8231== LEAK SUMMARY: ==8231== definitely lost: 112 bytes in 7 blocks ==8231== indirectly lost: 0 bytes in 0 blocks ==8231== possibly lost: 305,181 bytes in 464 blocks ==8231== still reachable: 2,408,681 bytes in 1,434 blocks ==8231== suppressed: 68,037 bytes in 163 blocks ==8231== Reachable blocks (those to which a pointer was found) are not shown. ==8231== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.10 sh ==8288== LEAK SUMMARY: ==8288== definitely lost: 112 bytes in 7 blocks ==8288== indirectly lost: 0 bytes in 0 blocks ==8288== possibly lost: 260,260 bytes in 389 blocks ==8288== still reachable: 1,756,174 bytes in 1,367 blocks ==8288== suppressed: 68,403 bytes in 163 blocks ==8288== Reachable blocks (those to which a pointer was found) are not shown. ==8288== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.11 sh ==8204== LEAK SUMMARY: ==8204== definitely lost: 5,376 bytes in 12 blocks ==8204== indirectly lost: 12,594 bytes in 13 blocks ==8204== possibly lost: 4,752 bytes in 7 blocks ==8204== still reachable: 10,686,048 bytes in 141,001 blocks ==8204== suppressed: 69,898 bytes in 166 blocks ==8204== Reachable blocks (those to which a pointer was found) are not shown. ==8204== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest
3.12 sh ==8293== LEAK SUMMARY: ==8293== definitely lost: 5,520 bytes in 13 blocks ==8293== indirectly lost: 1,844 bytes in 3 blocks ==8293== possibly lost: 4,128 bytes in 6 blocks ==8293== still reachable: 10,595,186 bytes in 140,953 blocks ==8293== suppressed: 68,382 bytes in 163 blocks ==8293== Reachable blocks (those to which a pointer was found) are not shown. ==8293== To see them, rerun with: --leak-check=full --show-leak-kinds=all ubuntu-latest

@carlkidcrypto carlkidcrypto merged commit 47670d0 into main Jul 30, 2024
35 checks passed
@carlkidcrypto carlkidcrypto deleted the feature/pull_in_more_upstream_fixes branch July 30, 2024 04:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant