Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature/minor improvements to use helpers #24

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Feature/minor improvements to use helpers #24

merged 6 commits into from
Nov 12, 2023

Conversation

carlkidcrypto
Copy link
Owner

Using the PurpleAirAPIHelpers where possible. Limiting the use of get, post, and delete in other files.

@carlkidcrypto
Update PurpleAirAPI.py
436bfb7 
- using the send_url_get_request where possible. Refactoring so we use the helpers send_url_get_request, send_url_post_request, send_url_delete_request, etc.
@carlkidcrypto
Fixes
db922a9 
- fixed the return value from the helper
- added a basic test file for PurpleAirAPI
- added a vscode config.
@carlkidcrypto
Sphinx
a83b4c7 
- updating docs
- bumping to 1.1.2
@carlkidcrypto
Tests
9843c69 
- minor renames to variables for testing files.
@carlkidcrypto carlkidcrypto self-assigned this Nov 12, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5116c60) 92.54% compared to head (59be588) 93.81%.

❗ Current head 59be588 differs from pull request most recent head 17f321b. Consider uploading reports for the commit 17f321b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   92.54%   93.81%   +1.27%     
==========================================
  Files          12       14       +2     
  Lines         456      566     +110     
==========================================
+ Hits          422      531     +109     
- Misses         34       35       +1
Files Coverage Δ
purpleair_api/PurpleAirAPI.py 100.00% <100.00%> (ø)
test/test_purpleair_read_api.py 97.91% <100.00%> (ø)
test/test_purpleair_write_api.py 95.65% <100.00%> (ø)
test/test_purpleair_api.py 98.14% <98.14%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlkidcrypto
Update test_purpleair_api.py
59be588 
- adding coverage for the getters
@carlkidcrypto
Rename
17f321b 
- renamed the test directory to tests
@carlkidcrypto carlkidcrypto merged commit 170b5b4 into main Nov 12, 2023
@carlkidcrypto carlkidcrypto deleted the feature/minor_improvements_to_use_helpers branch November 12, 2023 02:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@carlkidcrypto carlkidcrypto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlkidcrypto