Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

supported rspec3 matcher protocols #1370

Merged
merged 1 commit into from
May 8, 2014

Conversation

akiomik
Copy link
Contributor

@akiomik akiomik commented Apr 17, 2014

The following message is displayed when testing with rspec-rails v3.0.0beta.

Deprecation Warnings:

--------------------------------------------------------------------------
CarrierWave::Test::Matchers::BeIdenticalTo implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /home/vagrant/carrier/spec/uploaders/my_uploader_spec.rb:33:in `block (2 levels) in <top (required)>')
--------------------------------------------------------------------------

So I added failure_message_when_negated method.
(And negative_failure_message method is left for lower compatibility.)

Documentation is here:
https://www.relishapp.com/rspec/rspec-expectations/v/3-0/docs/custom-matchers/define-matcher#overriding-the-failure-message-when-negated

@akiomik
Copy link
Contributor Author

akiomik commented Apr 29, 2014

Now, I rebased it. Please merge :)

bensie added a commit that referenced this pull request May 8, 2014
@bensie bensie merged commit 09bfb3f into carrierwaveuploader:master May 8, 2014
@akiomik akiomik deleted the feature/support-rspec3 branch October 2, 2014 14:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants