Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Load all locales from config.i18n.available_locales #1521

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Load all locales from config.i18n.available_locales #1521

merged 1 commit into from
Dec 10, 2014

Conversation

printercu
Copy link
Contributor

@bensie
Copy link
Member

bensie commented Dec 10, 2014

Can you provide a bit more info as to what this changes/fixes?

@printercu
Copy link
Contributor Author

Hi! For now only en.yml is added to load_path. So for every other used locales one should copy yml files from gem/repo. Even if there is no need to edit translations.

After this changes are applied, all files according to config.i18n.available_locales will be added to load_path. Anyway it wont break anything: if config.i18n.available_locales is not set all files will be added to load_path. rails-i18n gem uses same strategy.

@bensie
Copy link
Member

bensie commented Dec 10, 2014

Awesome, thanks!

bensie added a commit that referenced this pull request Dec 10, 2014
Load all locales from config.i18n.available_locales
@bensie bensie merged commit 550af9d into carrierwaveuploader:master Dec 10, 2014
@printercu printercu deleted the patch-1 branch December 11, 2014 05:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants