Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move to Rspec 3 syntax and update rspec version #1630

Merged
merged 4 commits into from
Apr 23, 2015
Merged

Conversation

avgerin0s
Copy link
Member

Changelog

  • Update Rspec gem to version 3.2.0
  • Update Cucumber gem to version 2.0.0
  • Change all specs syntax to be compatible with the new rspec syntax.

Rspec reference

  • obj.stub(:method) is converted to allow(obj).to receive(:method)
  • expect(condition).to be_false is converted to expect(condition).to be_fausey
  • expect(condition).to be_true is converted to expect(condition).to be_truthy

The rationale behind this change is to have more clear specs and make it easier to maintain and extend our test suite which leads to easier adding/modifying of features.

@plribeiro3000
Copy link
Member

Looking good so far! Great work. 👍

@avgerin0s
Copy link
Member Author

@bensie @plribeiro3000 Please review it after the build passes :)

@avgerin0s avgerin0s changed the title [WIP] Move to Rspec 3 syntax Move to Rspec 3 syntax and update rspec version Apr 22, 2015
@avgerin0s
Copy link
Member Author

Fixed cucumber features also. I think it's ready.

@bensie
Copy link
Member

bensie commented Apr 23, 2015

Looks awesome!

bensie added a commit that referenced this pull request Apr 23, 2015
Move to Rspec 3 syntax and update rspec version
@bensie bensie merged commit 61ecdc5 into master Apr 23, 2015
@bensie bensie deleted the refactor-specs branch April 23, 2015 12:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants