Rename extension_white_list ~> extension_whitelist
#1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes: * Rename `extension_white_list` ~> `extension_whitelist` * Rename `extension_black_list` ~> `extension_blacklist`. * Rename i18n keys `extension_black_list_error` ~> `extension_blacklist_error` and `extension_white_list_error` ~> `extension_whitelist_error` Rename `check_blacklist!` internal callback ~> `check_extension_blacklist`, which is more precise and less prone to collisions with other callbacks methods names.
thomasfedb
added a commit
that referenced
this pull request
Jan 2, 2016
Rename file extension filtering methods for consistency
|
✨ |
mattmenefee
referenced
this pull request
Apr 1, 2016
|
This was mentioned in the 0.11.0 changelog, but my testing still shows the old behavior. |
Closed
weiqingtoh
added a commit
to Coursemology/coursemology2
that referenced
this pull request
Jan 4, 2017
- This is caused by a breaking change in carrierwaveuploader/carrierwave#1819
weiqingtoh
added a commit
to Coursemology/coursemology2
that referenced
this pull request
Jan 14, 2017
- This is caused by a breaking change in carrierwaveuploader/carrierwave#1819
weiqingtoh
added a commit
to Coursemology/coursemology2
that referenced
this pull request
Jan 15, 2017
- This is caused by a breaking change in carrierwaveuploader/carrierwave#1819
weiqingtoh
added a commit
to Coursemology/coursemology2
that referenced
this pull request
Jan 23, 2017
- This is caused by a breaking change in carrierwaveuploader/carrierwave#1819
weiqingtoh
added a commit
to Coursemology/coursemology2
that referenced
this pull request
Jan 24, 2017
- This is caused by a breaking change in carrierwaveuploader/carrierwave#1819
allenwq
pushed a commit
to Coursemology/coursemology2
that referenced
this pull request
Feb 16, 2017
- This is caused by a breaking change in carrierwaveuploader/carrierwave#1819
rutan
added a commit
to rutan/potmum
that referenced
this pull request
Jul 2, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
extension_white_list~>extension_whitelistextension_black_list~>extension_blacklist.extension_black_list_error~>extension_blacklist_errorand
extension_white_list_error~>extension_whitelist_errorRename
check_blacklist!internal callback ~>check_extension_blacklist, whichis more precise and less prone to collisions with other callbacks
methods names.