Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove locales from main repository #1848

Merged
merged 1 commit into from
Sep 4, 2016

Conversation

mehlah
Copy link
Member

@mehlah mehlah commented Jan 27, 2016

As a follow up to #1823
This PR removes locales from main repository, in favor of a separate one only concerned with locales:
https://github.com/craftsmen/carrierwave-i18n
In addition to the reasons I described in #1823, this repo have better specs for locales loading and and validity of yml manifests that should always be in sync with the "en" one.

Users of CarrierWave who might need additional locales could either add carrierwave-i18n gem or simply copy/paste the needed locales to their applications (we could add a Wiki page with an example).

Thoughts?

Extract another repository only concerned with locales:
https://github.com/craftsmen/carrierwave-i18n

Users of carrierwave who might need additional locales could either add
carrierwave-i18n gem or simply copy/paste the needed locales to their
applications.
@thomasfedb
Copy link
Contributor

What are you thoughts on this @bensie. Are you able to organise to bring the carrierwave-i18n repo into the @carrierwaveuploader org?

@bensie
Copy link
Member

bensie commented Jan 28, 2016

Yes I can take care of the repo/gem. I'm not sure I see the benefit to splitting this out, but don't feel strongly about it.

@bensie
Copy link
Member

bensie commented Jan 28, 2016

I've made the repo at https://github.com/carrierwaveuploader/carrierwave-i18n, both of you should be able to push to it.

@thomasfedb
Copy link
Contributor

@mehlah I will arrange to clone your repo into https://github.com/carrierwaveuploader/carrierwave-i18n. You may like to delete your repo and then fork from the official repo.

@thomasfedb
Copy link
Contributor

@mehlah I've lodged a few issue with the new -i18n repo. Once these are sorted out I'll be able to merge this PR.

@mshibuya mshibuya merged commit 5c27a88 into carrierwaveuploader:master Sep 4, 2016
mshibuya added a commit that referenced this pull request Sep 4, 2016
Remove locales from main repository
@mshibuya
Copy link
Member

mshibuya commented Sep 4, 2016

@mehlah Merged 🌟

@mehlah
Copy link
Member Author

mehlah commented Sep 4, 2016

Thanks @mshibuya.

I have not taking much time lately to keep up with CarrierWave updates.
Let me know pls if there is anything I can help with, especially for i18n as I worked on it before.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants