-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove locales from main repository #1848
Conversation
Extract another repository only concerned with locales: https://github.com/craftsmen/carrierwave-i18n Users of carrierwave who might need additional locales could either add carrierwave-i18n gem or simply copy/paste the needed locales to their applications.
What are you thoughts on this @bensie. Are you able to organise to bring the |
Yes I can take care of the repo/gem. I'm not sure I see the benefit to splitting this out, but don't feel strongly about it. |
I've made the repo at https://github.com/carrierwaveuploader/carrierwave-i18n, both of you should be able to push to it. |
@mehlah I will arrange to clone your repo into https://github.com/carrierwaveuploader/carrierwave-i18n. You may like to delete your repo and then fork from the official repo. |
@mehlah I've lodged a few issue with the new |
Remove locales from main repository
@mehlah Merged 🌟 |
Thanks @mshibuya. I have not taking much time lately to keep up with CarrierWave updates. |
As a follow up to #1823
This PR removes locales from main repository, in favor of a separate one only concerned with locales:
https://github.com/craftsmen/carrierwave-i18n
In addition to the reasons I described in #1823, this repo have better specs for locales loading and and validity of yml manifests that should always be in sync with the "en" one.
Users of CarrierWave who might need additional locales could either add carrierwave-i18n gem or simply copy/paste the needed locales to their applications (we could add a Wiki page with an example).
Thoughts?