Allow non-argument options to be passed in mini magick combine_options #2097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non-argument option is passed to mini magick processing using combine_options, the processing fails.
For example:
generates this command:
But processing is failing with mini_magick_processing_error. Changing
strip: nil
tostrip: ""
(empty string) also did not solve the problem.The only way I can get it to work is by changing the append_combine_options method to invoke the method without any arguments if nil options is passed: