Added fog_aws_accelerate options for fog storage provider #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS S3 supports accelerated file transfers to and from S3. [Transfer Acceleration](http://amzn.to/2jQmpAX) This introduces ability to configure Carrierwave to return accelerated public urls since Carrierwave constructs them by itself for speed concerns. To enable this feauture you need to set fog_aws_accelerate to true. It is false by default. Changes added: * fog_aws_accelerate added to fog aws configuration options * corresponding specs updated * corresponding docs updated
|
Hm, it seems build fails due to bundler cannot resolve some gems. That is interesting because Gemfile and lock files were not changed. |
|
Same blocker on CI for my PR. Looks like some underlying dependency maintenance to perform. |
|
Looks nice, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS S3 supports accelerated file transfers to and from S3.
Transfer Acceleration
This introduces ability to configure Carrierwave to return
accelerated public urls since Carrierwave constructs them
by itself for speed concerns.
To enable this feauture you need to set fog_aws_accelerate
to true. It is false by default.
Changes added: