Fix S3 path-style URL for host with dots for buckets that are placed in other regions than us-east-1 #2439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2359 added support for bucket names with period, but this only works for
us-east-1
region. For other regionss3.{aws-region}.amazonaws.com
needs to be used (see https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html#access-bucket-intro).This PR adds support for bucket names with period that are placed in regions other than
us-east-1
.Also, I'm wondering about one other thing regarding virtual-hosted–style URL. https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html#access-bucket-intro says:
Should carrierwave be updated to use
http://{bucket}.s3.{aws-region}.amazonaws.com
? If so should it:http://{bucket}.s3.{aws-region}.amazonaws.com
for all regions (this is what bothaws-sdk-s3
,carrierwave-aws
do and kind of whatfog-aws
does;fog-aws
useshttp://{bucket}.s3-{aws-region}.amazonaws.com
),http://{bucket}.s3.{aws-region}.amazonaws.com
only for regions created afterMarch 20, 2019
? (in that case carrierwave would require to have a list of regions created beforeMarch 20, 2019
)?