Add support for African currencies to CurrencyUnit enum #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Nigerian Naira (NGN), Ghanaian Cedis (GHS), Kenyan Shillings (KES), and South African Rands (ZAR) to the CurrencyUnit enum. - Updated the derivation_index method to include these new currencies. - Modified the FromStr and Display implementations to recognize and handle the new currency codes. - Enhanced serialization and deserialization to support the new currencies. This change is aimed at improving inclusivity and supporting the growing adoption of the Cashu protocol in African countries. By adding these currencies, users in Nigeria, Ghana, Kenya, and South Africa can now utilize the protocol more effectively with their local currencies.
Comment on lines
+400
to
+403
| Self::Ngn => Some(4), | ||
| Self::Ghs => Some(5), | ||
| Self::Kes => Some(6), | ||
| Self::Zar => Some(7), |
There was a problem hiding this comment.
Thanks for this PR. This isn't an issue introduced by this PR but the current way we do derivation path by just assigning numbers does not scale well and I don't think we should add more with this method. We've discussed the idea of using a short hashing method to achieve this. #464 (review)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is aimed at improving inclusivity and supporting the growing adoption of the Cashu protocol in African countries. By adding these currencies, users in Nigeria, Ghana, Kenya, and South Africa can now utilize the protocol more effectively with their local currencies.