make Keyset Id's member variables public

[codingpeanut157]

Description

Aligns with other structures by exposing Id's member variables, allowing developers to create Ids that don't follow the CDK protocol. [1]

[1] https://github.com/cashubtc/nuts/blob/main/02.md#deriving-the-keyset-id

[ok300]

NACK.

This would allow callers to bypass all the From implementations for Id ( From<&Keys>, FromStr, from_bytes etc) when creating Ids, which is unnecessary and dangerous.

[codingpeanut157]

NACK.

This would allow callers to bypass all the From implementations for Id ( From<&Keys>, FromStr, from_bytes etc) when creating Ids, which is unnecessary and dangerous.

That was the point of this PR: allow others to implement their own keyset Id generator algorithms.
Regarding the potential danger of exposing internals of Id: I don't see any extra danger, as you expose from_bytes method which substantially allows users to put anything that starts with Version00 in the Id.
Moreover, exposing internals of other structures that use Id like MintKeysInfo or MintKeyset do not mitigate that same danger.
And besides that, exposing internals of structs like Proof or MintKeyPair is equally dangerous IMHO.
So why not exposing Id and opening up cdk to custom implementations of eCash protocol...