Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow this to work with Aptana Studio 3 also #8

Closed
roshkins opened this issue May 17, 2014 · 2 comments
Closed

Allow this to work with Aptana Studio 3 also #8

roshkins opened this issue May 17, 2014 · 2 comments

Comments

@roshkins
Copy link

Is it possible to have this work with Aptana Studio also?

@caspark
Copy link
Owner

caspark commented May 18, 2014

I guess I should stop being surprised at Eclipse-based IDEs shipping on top of old versions of the Eclipse platform ;)

I've dropped the requirements so that the plugin only requires Eclipse 3.7.0 now. Fingers crossed nobody asks for a version compatible with Eclipse 3.6!

The newly cut v0.1.3 release contains this fix.

I tested it on Aptana Studio, and it does work, but there are a few issues with the shortcuts which appear to stem from Aptana reinventing a few parts of Eclipse:

  • Key binding conflicts which stop things from working out of the box. You need to rebind the following by going to Window >> Preferences >> General >> Keys (it helps if you sort by the "Binding" column):
    • Ctrl+Shift+I should only be bound to 1 command. I fixed this by unbinding Inspect, but you probably want to rebind Select All Occurrences instead, as that's probably the less useful of the two.
    • Ctrl+Shift+D should only be bound to 1 command. I fixed this by rebinding Select Next Occurrence to Ctrl+Shift+Alt+D (unbinding other commands isn't quite enough - see below)
  • Some sort of overrides on in the editor:
    • Ctrl+Shift+D seems to be hard coded to be bound to "Duplicate my selection and edit it in linked mode, or duplicate my line if I have no selection", regardless of what else it's bound to.
    • Esc will quit Eclipse linked mode editing but won't hide the associated decoration, and this is the case for this plugin and existing built in linked mode editing (such as the hardcoded duplication feature above). Some ways to hide the decorations are formatting using Ctrl+Shift+F or closing and reopening the file.

All this testing was on a plain text (.txt) file, i.e. using the simple built in Eclipse editor. Neither of the last 2 issues are present when I test on Eclipse 3.7, so as far as I'm concerned they're Aptana bugs.

They aren't show stoppers, but I expect that last one might get annoying so you may want to report it to Aptana, without mentioning this plugin: your bug report would look something like "when I select some text in an editor for a .txt file and press Ctrl+Shift+D, that text is duplicated and linked mode editing is activated, but pressing Escape does not hide the linked mode editing decoration".

@caspark caspark closed this as completed May 18, 2014
@roshkins
Copy link
Author

Thank you! You are awesome for fixing this so quickly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants