Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New key bindings for commands #17

Merged
merged 1 commit into from
Oct 13, 2014
Merged

Conversation

kaloyan-raev
Copy link
Contributor

Existing Ctrl+Shift+I and Ctrl+Shift+D key binding run with conflict
with commands with the same keybings from the Eclipse Platform and other
plugins.

This patch proposes new keybindings:

  • Select All Occurrences: Alt+F3 (Win, Linux) / Ctrl+Cmd+G (Mac)
  • Select Next Occurrence: Alt+J (Win, Linux) / Ctrl+G (Mac)

Existing Ctrl+Shift+I and Ctrl+Shift+D key binding run with conflict
with commands with the same keybings from the Eclipse Platform and other
plugins.

This patch proposes new keybindings:
  - Select All Occurrences: Alt+F3 (Win, Linux) / Ctrl+Cmd+G (Mac)
  - Select Next Occurrence: Alt+J (Win, Linux) / Ctrl+G (Mac)
@caspark
Copy link
Owner

caspark commented Oct 12, 2014

Thanks for figuring out these alternate keybindings; having Select All Occurrences match Sublime Text for OSX and non-OSX is a good idea.

It's a shame we can't do the same for Select Next Occurrence due to the default Ctrl+D binding, but Alt-J is somewhat similar to incremental find (Ctrl+J) so that works. Is Alt+J taken on OSX? It would be nice to have consistency, especially since ST has the same key binding across platforms for Select Next Occurrence.

@kaloyan-raev
Copy link
Contributor Author

I took the idea for the Alt+J / Ctrl+G key binding from IntelliJ - check here: http://blog.jetbrains.com/idea/2014/03/intellij-idea-13-1-rc-introduces-sublime-text-style-multiple-selections/

For Selecting All Occurrences they use Shift+Ctrl+Alt+J / Ctrl+Cmd+G. However that Shift+Ctrl+Alt+J is too many keys IMO, so I preferred to stick to Alt+F3 like in Sublime Text.

@caspark
Copy link
Owner

caspark commented Oct 13, 2014

Ah, Select Next Occurrence is Alt+Y in IntelliJ for me, so I didn't recognise it (still using Eclipse keybindings, haha).

Nice work. I'll merge your PR and make a release, hopefully sometime later today.

caspark added a commit that referenced this pull request Oct 13, 2014
New key bindings for commands
@caspark caspark merged commit 3efd1ce into caspark:master Oct 13, 2014
@kaloyan-raev
Copy link
Contributor Author

Thanks!
Now, I see that I forgot to update the README file in this pull request. I will push an additional change.

@caspark
Copy link
Owner

caspark commented Oct 13, 2014

No need, I'm doing it now :)

Edit: but I appreciate the thought!

@kaloyan-raev
Copy link
Contributor Author

OK. Thank you :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants