fix: rename lib.js to lib.web.js #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes TypeScript support for NodeNext/Node16/Bundler moduleResolution. The issue was that the ./dist/lib.js had a higher precedence than ./dist/lib/index.d.ts when TypeScript tried to resolve "./lib" imports/exports. Instead of renaming the whole lib/ folder I decided to add a infix to the lib.js artifact. But to solve the issue you could've renamed the directory instead.
|
Will be included in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes TypeScript support for NodeNext/Node16/Bundler moduleResolution.
The issue was that the
./dist/lib.jshas a higher precedence than./dist/lib/index.d.tswhen TypeScript tries to resolve"./lib"imports/exports.Instead of renaming the whole
lib/folder I decided to add a infix to thelib.jsartifact. But to solve the issue you could've renamed the directory instead.Resolves #386