Rebased with latest condor-rc branch, refactored HowTo #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meywood
previously approved these changes
Feb 14, 2025
meywood
requested changes
Feb 14, 2025
meywood
requested changes
Feb 17, 2025
| @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.WRAPPER_OBJECT) | ||
| @JsonSubTypes({ | ||
| @JsonSubTypes.Type(value = DelegatorKindPurse.class, name = "Purse"), | ||
| @JsonSubTypes.Type(value = DelegatorKindPublicKey.class, name = "PublicKey")}) | ||
| public interface DelegatorKind {} | ||
| public class DelegatorKind extends SeigniorageAllocation { |
There was a problem hiding this comment.
Why are you adding these fields to DelegatorKind it does not implement these in the Rust code. There are 2 different DelegatorKind enums in the rust codebase. The original needs to stay as it and a new delegator kind placeholder creating for the top level one.
/// Info about a seigniorage allocation for a delegator
DelegatorKind {
/// Delegator kind
delegator_kind: DelegatorKind,
/// Validator's public key
validator_public_key: PublicKey,
/// Allocated amount
amount: U512,
},
|
Please ensure all unit tests are passing |
meywood
requested changes
Feb 18, 2025
meywood
requested changes
Feb 18, 2025
| @Test | ||
| void validateGetStateEntityAccountCondor() throws IOException { | ||
|
|
||
| final String inputJson = getPrettyJson(loadJsonFromFile("entity/getstateentity-account-condor-test.json")); |
There was a problem hiding this comment.
Can't find this test resource "entity/getstateentity-account-condor-test.json"
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.