Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Solr schema scripts for ACL and CORE collections #1009

Closed
edwinzhng opened this issue Mar 3, 2020 · 2 comments
Closed

Refactor Solr schema scripts for ACL and CORE collections #1009

edwinzhng opened this issue Mar 3, 2020 · 2 comments
Assignees

Comments

@edwinzhng
Copy link
Member

Currently, JSON data for our Solr schemas are put directly into the setup scripts. There are two ways we can refactor this:

  1. Put JSON data in a separate file and have different schema files for adding or replacing fields, and allow our bash setup script to take the JSON data as a command line argument. In other words, we have a single setup script but multiple schema data files

  2. Keep JSON data in the bash setup scripts as-is, but support different flags such as "--replace" to replace existing fields or "--add" to add new fields. Here, we have multiple setup scripts for each specific collection (ACL, CORE).

We will also need to update documentation after this is done.

Option 1 seems cleaner to me but would like to hear other opinions @nikhilro @lintool

@nikhilro nikhilro self-assigned this Mar 3, 2020
@nikhilro
Copy link
Member

nikhilro commented Mar 3, 2020

  1. sounds good

@lintool
Copy link
Member

lintool commented Mar 28, 2020

Issue resolved in #1069 and and #1068.

@lintool lintool closed this as completed Mar 28, 2020
crystina-z pushed a commit to crystina-z/anserini that referenced this issue Oct 28, 2022
Pass on documentation refactoring - fixing, among other things:
+ pyserini.search -> pyserini.search.lucene
+ consistent indentation
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants