Use standalone EmbeddedSolrServer for Solr integration tests #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
============================================
- Coverage 53.66% 53.57% -0.10%
+ Complexity 829 823 -6
============================================
Files 154 154
Lines 8627 8627
Branches 1224 1224
============================================
- Hits 4630 4622 -8
- Misses 3618 3627 +9
+ Partials 379 378 -1
Continue to review full report at Codecov.
|
lintool
approved these changes
Sep 7, 2020
|
This is great, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1367,
EmbeddedSolrServerTestBaseenforces specific PRNG algorithm to be used (or not used) by JavaSecureRandom. This PR usesEmbeddedSolrServerby itself in tests to bypass this check.