Refactor Solr/ES scripts + docs #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
=========================================
Coverage 54.72% 54.72%
Complexity 853 853
=========================================
Files 148 148
Lines 8591 8591
Branches 1217 1217
=========================================
Hits 4701 4701
Misses 3495 3495
Partials 395 395 Continue to review full report at Codecov.
|
|
@adamyy can you take a quick look also, since you recently ran these experiments. Thanks! |
edwinzhng
approved these changes
Nov 10, 2020
| try: | ||
| response = requests.get('http://localhost:8983/') | ||
| response.raise_for_status() | ||
| except: return False | ||
| else: return True | ||
| except requests.exceptions.RequestException: |
There was a problem hiding this comment.
There's no other exception that could be raised here? (and elsewhere)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shaneding can you do a CR for me here also? Don't need to run the commands (I have), but at least sanity check to make sure I didn't screw up anything obvious.