Simple impact searcher #1592
Merged
Simple impact searcher #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for PR in pyserini, please see castorini/pyserini#684 |
lintool
reviewed
Jul 3, 2021
lintool
reviewed
Jul 5, 2021
|
@MXueguang is this ready for review? we need detailed tests for this since it's going to be at the core of lots of things moving forward... |
MXueguang
force-pushed
the
simple_impact_searcher
branch
from
b722f3f to
7fcb705
Compare
|
We need some tests to make sure that Currently, do we get exactly the same as the uniCOIL and DeepImpact repro in Anserini? If so, ready to merge? |
|
yes, ready to merge. |
lintool
approved these changes
Jul 8, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.