Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Final round of refactoring of regression framework #1717

Merged
merged 6 commits into from
Dec 30, 2021

Conversation

lintool
Copy link
Member

@lintool lintool commented Dec 28, 2021

Final installment of #1680

  • Refactored regression script, cleaned up dead code.
  • Renamed YAML params.

@lintool lintool marked this pull request as draft December 28, 2021 04:22
@codecov-commenter
Copy link

Codecov Report

Merging #1717 (f967e72) into master (6500560) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1717   +/-   ##
=========================================
  Coverage     57.58%   57.58%           
  Complexity     1032     1032           
=========================================
  Files           173      173           
  Lines          9781     9781           
  Branches       1344     1344           
=========================================
  Hits           5632     5632           
  Misses         3675     3675           
  Partials        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6500560...f967e72. Read the comment docs.

@lintool
Copy link
Member Author

lintool commented Dec 29, 2021

@MXueguang This is ready for review.

I've confirmed that regressions still work; most of the changes are cosmetic, so a quick sanity check will suffice.

Most of the substantive changes are in the regression script src/main/python/run_regression.py.

@lintool lintool marked this pull request as ready for review December 29, 2021 22:36
@lintool lintool merged commit 88299fc into master Dec 30, 2021
@lintool lintool deleted the regression-refactoring branch December 30, 2021 04:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants