Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update MS MARCO V2 regressions #1967

Merged
merged 12 commits into from
Sep 5, 2022
Merged

Update MS MARCO V2 regressions #1967

merged 12 commits into from
Sep 5, 2022

Conversation

lintool
Copy link
Member

@lintool lintool commented Aug 23, 2022

Add RM3 and Rocchio in cases where it's missing.

@lintool lintool marked this pull request as draft August 23, 2022 02:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #1967 (0d65c21) into master (5b8e292) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1967   +/-   ##
=========================================
  Coverage     58.30%   58.30%           
  Complexity     1067     1067           
=========================================
  Files           186      186           
  Lines         10147    10147           
  Branches       1398     1398           
=========================================
  Hits           5916     5916           
  Misses         3758     3758           
  Partials        473      473           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lintool lintool marked this pull request as ready for review September 5, 2022 17:12
@lintool lintool requested a review from yuki617 September 5, 2022 17:33
@lintool
Copy link
Member Author

lintool commented Sep 5, 2022

@yuki617 @MXueguang @ToluClassics Ready for review!

@MXueguang
Copy link
Member

seems some regression documents didn't provide instructions to download corpus?

@lintool
Copy link
Member Author

lintool commented Sep 5, 2022

seems some regression documents didn't provide instructions to download corpus?

Yea... that' unrelated to this specific PR, so let me circle back and do that later?

R@1000:
- 0.7731
- 0.7698
- name: rocchio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe unicoil-0shot+rocchio is a better name?

@lintool lintool merged commit 7a18f14 into master Sep 5, 2022
@lintool lintool deleted the regressions branch September 5, 2022 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants