-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add pyserini onnx encoder support #2113
add pyserini onnx encoder support #2113
Conversation
ce4efcc
to
cc73567
Compare
ca827a3
to
a015837
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2113 +/- ##
============================================
- Coverage 59.17% 59.05% -0.13%
Complexity 1200 1200
============================================
Files 194 194
Lines 11352 11377 +25
Branches 1488 1488
============================================
+ Hits 6718 6719 +1
- Misses 4146 4170 +24
Partials 488 488
☔ View full report in Codecov by Sentry. |
Can we have some test cases? At the very least, let's not have coverage go down? |
d01e9fe
to
782f98f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hey @ArthurChen189 I just got this issue:
This is on my M1 Mac, so floating point tolerance issues... should we adjust precision? |
Added support for Pyserini usage of ONNX on-the-fly query encoder
Related PR