Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DeepInference: Fix some bugs, add docs, refactor #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apiology
Copy link
Contributor

@apiology apiology commented Mar 1, 2025

Address some unhandled cases around rescue blocks after documenting and refactoring DeepInference based on my best understanding of it.

This fixes some false positives given by Solargraph while typechecking its own codebase at level 'strict'.

Address some unhandled cases around rescue blocks after documenting and refactoring DeepInference based on my best understanding of it.

This fixes some false positives given by Solargraph while typechecking its own codebase at level 'strict'.
@apiology
Copy link
Contributor Author

apiology commented Mar 1, 2025

@castwide: I've got a couple of more cases in the backlog to handle, and I think there's a larger refactor to be done, but I'd like to get your take on the terminology I'm using here first.

Happy to standardize on different terms or draw more/less fine-grained distinction between them, but having a common vocabulary is a good idea. In the meantime, having some definitions in front of me helped build a mental model and take the refactor far enough to get the begin/rescue case working.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant