Improve handling for SHELL environment variable: #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use boolean conditional for checking shell_path to catch empty strings. * Throw an error if shell_path does not exist.
|
It might be irrelevant, but in the dotfiles I am using SHELL is being set to 'bash' rather than '/bin/bash' which resulted in this commit breaking my catkin_tools. Since the fix is simple and I am not the original creator of the script I am not reporting any particular issue, but rather asking if it is good to assume that SHELL must be '/bin/bash' and cannot be 'bash'. |
|
I'm not sure if we can safely assume that the value in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use boolean conditional for checking shell_path to catch empty strings.
Throw an error if shell_path does not exist.
This is a rebased version of #414